stdenv: Fix inputDerivation for __structuredAttrs (again?)#463882
Closed
infinisil wants to merge 2 commits intoNixOS:masterfrom
Closed
stdenv: Fix inputDerivation for __structuredAttrs (again?)#463882infinisil wants to merge 2 commits intoNixOS:masterfrom
infinisil wants to merge 2 commits intoNixOS:masterfrom
Conversation
Supposedly NixOS#368226 fixed it, but either nobody actually tested it or older Nix versions were fine, but all currently available Nix versions, including 2.24 and 2.32 complain about it: building '/nix/store/9n4hwzk8s74n6cq8dlxa4qas9jchsbgc-inputDerivation.drv'... error: output '/nix/store/l3gmc01pwa42rzq9riv8wm3skzkm144r-inputDerivation' is not allowed to refer to the following paths: /nix/store/k5z8rkvj1fn1nrf05l5a86aflc5s1p6m-stdenv-linux /nix/store/l3gmc01pwa42rzq9riv8wm3skzkm144r-inputDerivation /nix/store/l622p70vy8k5sh7y5wizi5f2mic6ynpg-source-stdenv.sh /nix/store/qsydfxm1vq6q9jac2kq3r8kn0xdmsldf-bash-5.3p3 /nix/store/shkw4qm9qcw5sc5n1k5jznc83ny02r39-default-builder.sh This commit fixes it (again?) and adds a regression test
13 tasks
Otherwise it can be very confusing, because you have one "hello" derivation which actually builds hello, while the other doesn't
Contributor
|
CI fails here. |
13 tasks
Member
Author
|
Done by #469652 now :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supposedly #368226 fixed it, but either nobody actually tested it or older Nix versions were fine, but all currently available Nix versions, including 2.24 and 2.32 complain about it:
This commit fixes it (again?) and adds a regression test
Ping @ShamrockLee
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.