stdenv.mkDerivation: inputDerivation: fix for __structuredAttrs = true#368226
Merged
infinisil merged 1 commit intoNixOS:masterfrom Dec 31, 2024
Merged
Conversation
github-actions
bot
added
6.topic: stdenv
Contributor
Author
|
Contributor
Author
nix-owners
bot
requested review from
Artturin,
Ericson2314,
RossComputerGuy,
emilazy,
philiptaron and
reckenrode
wegank
added
the
12.approvals: 1
Contributor
Author
|
OfBorg failed to build |
Contributor
|
Basically flat on performance. |
infinisil
approved these changes
Dec 31, 2024
infinisil
added a commit
to tweag/nixpkgs
that referenced
this pull request
Nov 21, 2025
Supposedly NixOS#368226 fixed it, but either nobody actually tested it or older Nix versions were fine, but all currently available Nix versions, including 2.24 and 2.32 complain about it: building '/nix/store/9n4hwzk8s74n6cq8dlxa4qas9jchsbgc-inputDerivation.drv'... error: output '/nix/store/l3gmc01pwa42rzq9riv8wm3skzkm144r-inputDerivation' is not allowed to refer to the following paths: /nix/store/k5z8rkvj1fn1nrf05l5a86aflc5s1p6m-stdenv-linux /nix/store/l3gmc01pwa42rzq9riv8wm3skzkm144r-inputDerivation /nix/store/l622p70vy8k5sh7y5wizi5f2mic6ynpg-source-stdenv.sh /nix/store/qsydfxm1vq6q9jac2kq3r8kn0xdmsldf-bash-5.3p3 /nix/store/shkw4qm9qcw5sc5n1k5jznc83ny02r39-default-builder.sh This commit fixes it (again?) and adds a regression test
13 tasks
Member
|
Oddly enough, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
<drv>.inputDerivaitonevaluate without warnings messages regarding theoutputChecks.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.