python3.pkgs.django-cacheops: update, fix build, refactor to run all tests#243108
Merged
yu-re-ka merged 3 commits intoNixOS:masterfrom Jul 14, 2023
yu-re-ka:django-cacheops
Merged
python3.pkgs.django-cacheops: update, fix build, refactor to run all tests#243108yu-re-ka merged 3 commits intoNixOS:masterfrom yu-re-ka:django-cacheops
yu-re-ka merged 3 commits intoNixOS:masterfrom
yu-re-ka:django-cacheops
Conversation
github-actions
bot
added
the
6.topic: python
leona-ya
reviewed
Jul 12, 2023
Member
leona-ya
left a comment
leona-ya
left a comment
There was a problem hiding this comment.
Somewhat unhappy with the packaging of before_after, but it seems like there's no better way to do (even if we would package unstable, we would need one of the patches).
Member
There was a problem hiding this comment.
seems like you can drop mock and pythonRelaxDepsHook
Contributor
Author
Yes. before_after seems to be quite badly maintained. I kindly asked the maintainers to merge the PR and create a new release here |
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
Author
|
@ofborg build python3.pkgs.django-cacheops |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
12 tasks
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
Contributor
Author
|
I tried to fix the darwin build as well but couldn't figure it out |
Member
|
We can mark that broken for now |
SuperSandro2000
approved these changes
Jul 14, 2023
SuperSandro2000
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)