Skip to content

peering-manager: add meta section#243102

Merged
SuperSandro2000 merged 4 commits intoNixOS:masterfrom
yu-re-ka:peering-manager-meta
Jul 14, 2023
Merged

peering-manager: add meta section#243102
SuperSandro2000 merged 4 commits intoNixOS:masterfrom
yu-re-ka:peering-manager-meta

Conversation

@yu-re-ka
Copy link
Copy Markdown
Contributor

@yu-re-ka yu-re-ka commented Jul 12, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 12, 2023
@yu-re-ka yu-re-ka requested a review from SuperSandro2000 July 12, 2023 17:07
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 12, 2023
@SuperSandro2000
Copy link
Copy Markdown
Member

SuperSandro2000 commented Jul 12, 2023

Other than that the tests fails with the following error this is good to merge.

       error: Package ‘python3.10-django-cacheops-6.2’ in /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ofborg-evaluator-7/pkgs/development/python-modules/django-cacheops/default.nix:56 is marked as broken, refusing to evaluate.

@yu-re-ka
Copy link
Copy Markdown
Contributor Author

yu-re-ka commented Jul 13, 2023

The breakage is being dealt with in #243108

@yu-re-ka yu-re-ka mentioned this pull request Jul 14, 2023
Merged
17 tasks
@SuperSandro2000 SuperSandro2000 merged commit 9e010ed into NixOS:master Jul 14, 2023
@yu-re-ka yu-re-ka deleted the peering-manager-meta branch July 14, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yayayayaka yayayayaka yayayayaka approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up This PR removes packages or removes other cruft 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yu-re-ka @SuperSandro2000 @yayayayaka @yuyuyureka