peering-manager: init#202159
Merged
yu-re-ka merged 3 commits intoNixOS:masterfrom Dec 7, 2022
yu-re-ka:peering-manager
Merged
Conversation
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
8.has: package (new)
n0emis
approved these changes
Dec 7, 2022
1 task
Contributor
|
Successfully created backport PR #204978 for |
dotlambda
reviewed
Jul 12, 2023
Member
dotlambda
left a comment
dotlambda
left a comment
There was a problem hiding this comment.
packageOverrides is exactly the way to go here :)
But meta is missing completely.
| tests = { | ||
| inherit (nixosTests) peering-manager; | ||
| }; | ||
| }; |
Member
There was a problem hiding this comment.
either I can't find it or meta is missing
Contributor
Author
There was a problem hiding this comment.
this is the same as what dotlambda commented two days ago, and is fixed by #243102, which you reviewed
Member
There was a problem hiding this comment.
upsi, totally missed the other comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notesTODO