Skip to content

tests: fix URL literals in functional tests#15148

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:fix-tests
Feb 5, 2026
Merged

tests: fix URL literals in functional tests#15148
Mic92 merged 1 commit intoNixOS:masterfrom
Mic92:fix-tests

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 4, 2026

This is a preparation for stabilizing NoUrlLiterals

@Mic92 Mic92 requested a review from edolstra as a code owner February 4, 2026 23:01
@github-actions github-actions bot added the with-tests Issues related to testing. PRs with tests have some priority label Feb 4, 2026
@Mic92 Mic92 changed the title Tests: Fix URL literals in functional tests tests: fix URL literals in functional tests Feb 4, 2026
@Mic92 Mic92 enabled auto-merge February 5, 2026 00:53
@Mic92 Mic92 added this pull request to the merge queue Feb 5, 2026
@xokdvium
Copy link
Contributor

xokdvium commented Feb 5, 2026

Makes sense to update the test suite, I'm a bit on the fence about saying that it's deprecated though. Realistically we do want to be able to eval old nixpkgs, so the flag is not going away unless we want to stop being able to eval old code (which I think is invaluable and mustn't change unless absolutely necessary). Ideally I'd get something like nixpkgs from 2016 in our test suite for eval regressions.

Merged via the queue into NixOS:master with commit dcc71da Feb 5, 2026
14 checks passed
@Mic92 Mic92 deleted the fix-tests branch February 5, 2026 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants