Skip to content

Add support for deprecated features#15150

Open
Mic92 wants to merge 1 commit intoNixOS:masterfrom
Mic92:deprecation-infra
Open

Add support for deprecated features#15150
Mic92 wants to merge 1 commit intoNixOS:masterfrom
Mic92:deprecation-infra

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 5, 2026

Depends on #15148

Motivation is being able to remove url literals in #15151 while still having a way to evaluate old nix code.

@Mic92 Mic92 requested a review from edolstra as a code owner February 5, 2026 00:19
@github-actions github-actions bot added documentation new-cli Relating to the "nix" command with-tests Issues related to testing. PRs with tests have some priority labels Feb 5, 2026
@Mic92
Copy link
Member Author

Mic92 commented Feb 5, 2026

This code is largely based on what Lix already added. Having the same option is beneficial for inter-operability.

@Mic92 Mic92 force-pushed the deprecation-infra branch from 8806e95 to bf0b7e6 Compare February 5, 2026 00:24
Co-authored-by: piegames <git@piegames.de>
Co-authored-by: eldritch horrors <pennae@lix.systems>
@Mic92 Mic92 force-pushed the deprecation-infra branch from bf0b7e6 to d261304 Compare February 5, 2026 00:30
@Mic92
Copy link
Member Author

Mic92 commented Feb 5, 2026

An alternative to this could be just printing warnings otherwise?

@Mic92
Copy link
Member Author

Mic92 commented Feb 5, 2026

This one suggested warnings? #10281

Copy link
Contributor

@xokdvium xokdvium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think the less deceptive approach would be #10262. The actual design of the options isn't final and needs some massaging, but the idea is good - just needs an implementation.

@dpulls
Copy link

dpulls bot commented Feb 5, 2026

🎉 All dependencies have been resolved !

{},
"deprecated-features",
R"(
Deprecated features that are enabled. (Currently there are none.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Deprecated features that are enabled. (Currently there are none.)
Deprecated features that are enabled.

Seems like that's not true with URL literals?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but that's introduced in the next PR and not this one.

@Ericson2314
Copy link
Member

I do think it would be better if URL literals was an eval setting rather than overall setting.

@Mic92
Copy link
Member Author

Mic92 commented Feb 5, 2026

I do think it would be better if URL literals was an eval setting rather than overall setting.

Shouldn't be a big deal to move, but I am not so sure if all "warnings" would be in the eval category: #10281 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation new-cli Relating to the "nix" command with-tests Issues related to testing. PRs with tests have some priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants