Open
Conversation
Member
Author
|
This code is largely based on what Lix already added. Having the same option is beneficial for inter-operability. |
8806e95 to
bf0b7e6
Compare
Co-authored-by: piegames <git@piegames.de> Co-authored-by: eldritch horrors <pennae@lix.systems>
bf0b7e6 to
d261304
Compare
Member
Author
|
An alternative to this could be just printing warnings otherwise? |
Member
Author
|
This one suggested warnings? #10281 |
|
🎉 All dependencies have been resolved ! |
Ericson2314
reviewed
Feb 5, 2026
| {}, | ||
| "deprecated-features", | ||
| R"( | ||
| Deprecated features that are enabled. (Currently there are none.) |
Member
There was a problem hiding this comment.
Suggested change
| Deprecated features that are enabled. (Currently there are none.) | |
| Deprecated features that are enabled. |
Seems like that's not true with URL literals?
Member
Author
There was a problem hiding this comment.
yeah, but that's introduced in the next PR and not this one.
Member
|
I do think it would be better if URL literals was an eval setting rather than overall setting. |
Member
Author
Shouldn't be a big deal to move, but I am not so sure if all "warnings" would be in the eval category: #10281 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #15148
Motivation is being able to remove url literals in #15151 while still having a way to evaluate old nix code.