libstore: split out local build and store related settings under LocalSettings#15101
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 5, 2026
Merged
Conversation
github-actions
bot
added
new-cli
amaanq
force-pushed
the
split-local-store-settings
branch
3 times, most recently
from
8200988 to
f2baf21
Compare
Member
Author
|
|
amaanq
force-pushed
the
split-local-store-settings
branch
3 times, most recently
from
19184d1 to
4d31e80
Compare
Ericson2314
reviewed
Jan 27, 2026
Ericson2314
reviewed
Jan 27, 2026
Ericson2314
reviewed
Jan 27, 2026
Ericson2314
reviewed
Jan 27, 2026
Ericson2314
reviewed
Jan 27, 2026
Ericson2314
reviewed
Jan 27, 2026
amaanq
force-pushed
the
split-local-store-settings
branch
2 times, most recently
from
6e941af to
aacc54f
Compare
github-actions
bot
added
the
with-tests
amaanq
force-pushed
the
split-local-store-settings
branch
2 times, most recently
from
97a3088 to
0dfa372
Compare
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
force-pushed
the
split-local-store-settings
branch
from
0dfa372 to
a1ab81f
Compare
|
🎉 All dependencies have been resolved ! |
Ericson2314
force-pushed
the
split-local-store-settings
branch
2 times, most recently
from
948dd0d to
7751945
Compare
Ericson2314
approved these changes
Feb 5, 2026
auto-merge was automatically disabled
February 5, 2026 15:26
Head branch was pushed to by a user without write access
amaanq
force-pushed
the
split-local-store-settings
branch
from
7751945 to
8e65818
Compare
…alSettings` The global `Settings` struct contained many settings that only apply to local builds or the local store (sandbox configuration, GC settings, build user groups, etc.). This commit extracts these into a dedicated `LocalSettings` struct in its own header, along with `GCSettings` and `AutoAllocateUidSettings`. This improves code organization and prepares for eventually making these per-store settings in the future. Settings are accessed via `getLocalSettings()` from the global settings object or through `LocalStoreConfig::getLocalSettings()` for store-specific access.
amaanq
force-pushed
the
split-local-store-settings
branch
from
8e65818 to
afd40ad
Compare
Member
Author
|
I rebased and force-pushed as CI was failing due to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The global
Settingsstruct contained many settings that only apply to local builds or the local store (sandbox configuration, GC settings, build user groups, etc.). This commit extracts these into a dedicatedLocalSettingsstruct in its own header, along withGCSettingsandAutoAllocateUidSettings.This improves code organization and prepares for eventually making these per-store settings in the future. Settings are accessed via
getLocalSettings()from the global settings object or throughLocalStoreConfig::getLocalSettings()for store-specific access.Context
Depends on #15119
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.