libstore: add PersonalityArgs struct for setPersonality#15117
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Jan 29, 2026
Merged
libstore: add PersonalityArgs struct for setPersonality#15117Ericson2314 merged 1 commit intoNixOS:masterfrom
PersonalityArgs struct for setPersonality#15117Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
amaanq
force-pushed
the
move-impersonate-linux
branch
from
afbfab7 to
e3b1631
Compare
amaanq
changed the title
PersonalityArgs struct for setPersonality
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
Ericson2314
reviewed
Jan 29, 2026
This introduces a `PersonalityArgs` struct to pass named arguments to `setPersonality`. The `impersonateLinux26` setting is now passed from the call site rather than read from settings inside the function.
amaanq
force-pushed
the
move-impersonate-linux
branch
from
e3b1631 to
351b8dd
Compare
Ericson2314
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This introduces a
PersonalityArgsstruct to pass named arguments tosetPersonality. TheimpersonateLinux26setting is now passed from the call site rather than read from settings inside the function.Context
This was parted out from #15101
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.