Sync config/initializers/devise.rb with devise 4.9.3 template#301
Merged
Sync config/initializers/devise.rb with devise 4.9.3 template#301
Conversation
Changes: - config.stretches is now 1 in the test env, which makes the tests faster. - config.stretches increased from 10 to 12 in non-test env (note that the cost increases exponentially). - Adopt new (more permissive) defaults for config.maximum_attempts and config.reset_password_within. - The template now sets `config.skip_session_storage = [:http_auth]`, but it shouldn't affect us because we appear to use :param_auth (checked by logging the value during login). - The template now sets `expire_all_remember_me_on_sign_out = true`, but this is the default so it doesn't make a difference. - Some defaults commented out.
Holmes98
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
config.stretches is now 1 in the test env, which makes the tests much faster (see #290).
config.stretches increased from 10 to 12 in non-test env (note that the cost increases exponentially).
Adopt new (more permissive) defaults for config.maximum_attempts and config.reset_password_within.
The template now sets
config.skip_session_storage = [:http_auth], but it shouldn't affect us because we appear to use :param_auth (checked by logging the value during login).The template now sets
expire_all_remember_me_on_sign_out = true, but this is the default so it doesn't make a difference.Some defaults commented out.