Update to Rails 4.2

[bagedevimo]

Steps:

• Update Gemfile
• bundle update --conservative rails actionpack railties activerecord activemodel activesupport rack responders

There are lots of warnings & deprecations, but nothing is failing in
the test suite.

[bagedevimo]

Current dependencies on/for this PR:

• master
  • PR Extract DevelopmentMailInterceptor setup from config/environments/ #198
    • PR Update to Rails 4.2 #199 👈
      • PR Add & configure sentry-raven #221
      • PR Update rails templated files for Rails 4.2 upgrade #200

This stack of pull requests is managed by Graphite.

[tom93]

Minor:

There is a change to Rack that makes it listen on localhost instead of 0.0.0.0 in development to only allow connections from the current host (source).

A side effect of this is that on some systems localhost might resolve to IPv6, which means connecting via 127.0.0.1 fails. I'd like to be able to continue using 127.0.0.1; looking into this.

Edit: Better (official) source. It says "both http://127.0.0.1:3000/ and http://localhost:3000/ will continue to work" but that's not the case for me. I know I can use rails server -b 127.0.0.1 but that's annoying. I'm thinking of using the trick from here (found via Stack Overflow and the FastRuby article), but with 127.0.0.1 instead of 0.0.0.0. (Separate PR.)

[tom93]

Re commit message: I have draft fixes for two classes of deprecations in #219 and #220, only one left:

DEPRECATION WARNING: The configuration option config.serve_static_assets has been renamed to config.serve_static_files to clarify its role (it merely enables serving everything in the public folder and is unrelated to the asset pipeline). The serve_static_assets alias will be removed in Rails 5.0. Please migrate your configuration files accordingly. (called from block in <top (required)> at /home/user/nztrain/config/environments/test.rb:37)

[bagedevimo]

Minor:

There is a change to Rack that makes it listen on localhost instead of 0.0.0.0 in development to only allow connections from the current host (source).

A side effect of this is that on some systems localhost might resolve to IPv6, which means connecting via 127.0.0.1 fails. I'd like to be able to continue using 127.0.0.1; looking into this.

Edit: Better (official) source. It says "both http://127.0.0.1:3000/ and http://localhost:3000/ will continue to work" but that's not the case for me. I know I can use rails server -b 127.0.0.1 but that's annoying. I'm thinking of using the trick from here (found via Stack Overflow and the FastRuby article), but with 127.0.0.1 instead of 0.0.0.0. (Separate PR.)

Ha, I didn't notice this because i've been doing local development with -b 0.0.0.0 intentionally

[bagedevimo]

Re commit message: I have draft fixes for two classes of deprecations in #219 and #220, only one left:

DEPRECATION WARNING: The configuration option config.serve_static_assets has been renamed to config.serve_static_files to clarify its role (it merely enables serving everything in the public folder and is unrelated to the asset pipeline). The serve_static_assets alias will be removed in Rails 5.0. Please migrate your configuration files accordingly. (called from block in <top (required)> at /home/user/nztrain/config/environments/test.rb:37)

Awesome - I still think it's worth merging these all separately and potentially even deploying, then merging the fixes. Makes it a little easier to spot issues that occurred due to the upgrade vs due to fixing the deprecs - but i'm not very passionate about this.