Conversation
Contributor
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Dec 21, 2023
Merged
tom93
previously requested changes
Dec 21, 2023
Contributor
tom93
left a comment
tom93
left a comment
There was a problem hiding this comment.
Is this missing the removal from config/environments/development.rb?
bagedevimo
force-pushed
the
12-21-Extract_DevelopmentMailInterceptor_setup_from_config/environment
branch
from
3c4986c to
88453ec
Compare
This makes rails upgrades easier, as it means the diff between the template-added is near-zero. There's no reason not to set this up here, we just have to be a little careful about rails load order (use Mail#register_interceptor instead of ActionMailer).
bagedevimo
force-pushed
the
12-21-Extract_DevelopmentMailInterceptor_setup_from_config/environment
branch
from
88453ec to
8d27564
Compare
Contributor
Author
Yes, lol. Fixed now. |
tom93
approved these changes
Dec 22, 2023
tom93
changed the title
tom93
deleted the
12-21-Extract_DevelopmentMailInterceptor_setup_from_config/environment
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes rails upgrades easier, as it means the diff between the
template-added is near-zero. There's no reason not to set this up here,
we just have to be a little careful about rails load order (use
Mail#register_interceptor instead of ActionMailer).