Skip to content

Updating hex text input to work with or without a hashtag #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DaveZMB wants to merge 1 commit into from
Closed

Updating hex text input to work with or without a hashtag #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/components/Verte.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,6 +353,10 @@ export default {
inputChanged (event, value) {
const el = event.target;
if (this.currentModel === 'hex') {
if (typeof el.value !== 'object' && el.value.indexOf('#') !== 0) {
el.value = '#' + el.value;
}

Comment on lines +356 to +359
Copy link

@groovetrain groovetrain Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like specifically checking for there being a '#' as the first character, I'd amend the replacement as follows, in case it's later on in the string (perhaps doing too much sanitation, but whatever, I'll leave it up to you if you think it's important enough)

el.value = '#' + el.value.replace(/[^0-9A-F]/ig, '').substr(0,6);

Copy link

@groovetrain groovetrain Jan 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also know you probably spent an annoying amount of time finding where to actually make this change, so for that I applaud you! :)

this.selectColor(el.value);
return;
}
Expand Down