Updating hex text input to work with or without a hashtag

[DaveZMB]

UAT feedback "Missing # in color code will not work"

The color picker is built using a 3rd party plugin, unfortunately that plugin does not support hex values that don't include a starting # so I had to update their code to make it work.

There are multiple places in the code that ensure the hex value contains a starting #, so rather than trying to update them all to work with & without a # I am simply ensuring that all hex values start with a # before doing any processing.

I have submitted a bug report and a pull request to the original package, but it doesn't look like there have been any changes since the master branch was created so I'm not very hopeful that they will pull it in.

So I'm thinking to switch mcms to use our [fixed] forked version, but could be easily convinced that we should just change to a different 3rd party color picker instead.

Fwiw, this plugin was selected by Kristine because it looked and behaved how she wanted. I'm sure we can find another plugin that is pretty similar and doesn't have this # issue, but there would probably be a bit more testing involved in switching plugins.

[groovetrain]

If this works, it's my opinion that we should move forward with our own forked version, since it works. It's less work, and whatever problems there are, we already know about them.

[groovetrain]

I like specifically checking for there being a '#' as the first character, I'd amend the replacement as follows, in case it's later on in the string (perhaps doing too much sanitation, but whatever, I'll leave it up to you if you think it's important enough)

el.value = '#' + el.value.replace(/[^0-9A-F]/ig, '').substr(0,6);

[groovetrain]

I also know you probably spent an annoying amount of time finding where to actually make this change, so for that I applaud you! :)