Skip to content

GEOPY-2623: colour for Curve is not working the same way as other objects #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 5 commits into from
Jan 7, 2026
Merged

GEOPY-2623: colour for Curve is not working the same way as other objects #827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aa5688d
fix the visual parameter bug
Dec 19, 2025
b0b7d85
Merge branch 'develop' into GEOPY-2623
MatthieuCMira Jan 6, 2026
2bb4ee1
always set the transparency if not present
Jan 6, 2026
a95c3d9
dom's comment:
Jan 6, 2026
46b6293
Fix up copyright years
domfournier Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README-dev.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,4 +454,4 @@ To build the api docs using autodocs

Copyright
^^^^^^^^^
Copyright (c) 2025 Mira Geoscience Ltd.
Copyright (c) 2020-2026 Mira Geoscience Ltd.
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ Third Party Software notices and/or additional terms and conditions are located

Copyright
^^^^^^^^^
Copyright (c) 2025 Mira Geoscience Ltd.
Copyright (c) 2020-2026 Mira Geoscience Ltd.


Citing geoh5py
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/blob_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/boolean_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/color_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/colour.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/data_association_enum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/data_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/data_unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/datetime_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/filename_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/float_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/geometric_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/integer_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/numeric_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/reference_value_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/referenced_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/text_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/data/unknown_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
9 changes: 6 additions & 3 deletions geoh5py/data/visual_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down Expand Up @@ -107,10 +107,13 @@ def colour(self) -> None | list:
def colour(self, rgb: list | tuple | np.ndarray):
if (
not isinstance(rgb, (list, tuple, np.ndarray))
or len(rgb) != 3
or len(rgb) not in [3, 4]
or not all(isinstance(val, int) for val in rgb)
):
raise TypeError("Input 'colour' values must be a list of 3 integers.")
raise TypeError("Input 'colour' values must be a list of 3 or 4 integers.")

if len(rgb) == 3:
rgb = list(rgb) + [255]

byte_string = "".join(f"{val:02x}" for val in rgb)
byte_string.join(f"{255:02x}") # alpha value
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/drillhole.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/giftools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/group_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/integrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/interpretation_section.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/maps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/notype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/property_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/property_group_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/property_group_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/root.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/simpeg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
2 changes: 1 addition & 1 deletion geoh5py/groups/survey.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
# Copyright (c) 2025 Mira Geoscience Ltd. '
# Copyright (c) 2020-2026 Mira Geoscience Ltd. '
# '
# This file is part of geoh5py. '
# '
Expand Down
Loading