Skip to content

Conversation

@MatthieuCMira
Copy link
Contributor

@MatthieuCMira MatthieuCMira commented Dec 19, 2025

GEOPY-2623 - colour for Curve is not working the same way as other objects
fix the visual parameter bug for curve and surface

@github-actions github-actions bot changed the title GEOPY-2623 GEOPY-2623: colour for Curve is not working the same way as other objects Dec 19, 2025
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.08%. Comparing base (5849378) to head (2bb4ee1).

Files with missing lines Patch % Lines
geoh5py/data/visual_parameters.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #827      +/-   ##
===========================================
+ Coverage    91.07%   91.08%   +0.01%     
===========================================
  Files          115      115              
  Lines        10119    10121       +2     
  Branches      1877     1878       +1     
===========================================
+ Hits          9216     9219       +3     
+ Misses         481      480       -1     
  Partials       422      422              
Files with missing lines Coverage Δ
geoh5py/__init__.py 55.55% <ø> (ø)
geoh5py/data/__init__.py 100.00% <ø> (ø)
geoh5py/data/blob_data.py 66.66% <ø> (ø)
geoh5py/data/boolean_data.py 100.00% <ø> (ø)
geoh5py/data/color_map.py 92.15% <ø> (ø)
geoh5py/data/colour.py 98.30% <ø> (ø)
geoh5py/data/data.py 90.78% <ø> (ø)
geoh5py/data/data_association_enum.py 100.00% <ø> (ø)
geoh5py/data/data_type.py 94.63% <ø> (ø)
geoh5py/data/data_unit.py 66.66% <ø> (ø)
... and 105 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

benk-mira
benk-mira previously approved these changes Dec 19, 2025

@colour.setter
def colour(self, rgb: list | tuple | np.ndarray):
# all the CellObjects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean out

@pytest.mark.parametrize(
"object_type,object_name,extra_params",
[
(Points, "TestPoints", {}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a grid object here too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants