feat: Enable ppom on other chains by segun · Pull Request #22633 · MetaMask/metamask-extension

segun · 2024-01-23T08:11:53Z

Description

This PR depends on

Olu/enable ppom on more networks ppom-validator#90

Once these PRs are merged, and for the Controller PR, a new controller version released, we'll be able to support additional networks on extension and we should enable the feature on them.

The following networks are supported by this change.

Ethereum Mainnet (already done)
BNB chain
Polygon
Arbitrum
Optimism
Avalanche
Linea

NOTE: So that we can test this branch, we made some changes in the package.json, and ppom.js once the above 2 dependency PRs are merged, we should revert the changes and especially in the change below, we should be using the deployed version of PPOM Validator.

    "@metamask/ppom-validator": "MetaMask/ppom-validator#olu/send-ppom-on-more-networks",

Related issues

Fixes: #1692
Blocked By: #21436, #90

Manual testing steps

Launch MM
Change network to any of the chains above other than Mainnet
Open this modified testdapp
Connect MM and click on any of the PPOM buttons
You should not see any blockaid banner
Checkout this branch, build and restart MM
Repeat 2-4
You should see blockaid banner when you click on any of the PPOM buttons

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-01-23T08:12:08Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-01-23T11:12:54Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/ppom-validator@0.22.0	Transitive: environment, filesystem, network, shell, unsafe	`+147`	25.9 MB	brad.decker, danfinlay, gudahtt, ...9 more
npm/builtin-modules@3.3.0	unsafe	`0`	4.51 kB	sindresorhus
npm/crypto-js@4.2.0	None	`0`	487 kB	evanvosberg
npm/eslint-compat-utils@0.1.2	filesystem Transitive: environment, shell, unsafe	`+61`	8.79 MB	ota-meshi
npm/eslint-plugin-es-x@7.5.0	Transitive: environment, filesystem, shell, unsafe	`+62`	9.16 MB	eslint-community-bot
npm/eslint-plugin-n@16.6.2	filesystem Transitive: environment, shell, unsafe	`+74`	9.96 MB	weiran.zsd
npm/get-tsconfig@4.7.2	filesystem, unsafe	`+1`	116 kB	hirokiosame
npm/is-builtin-module@3.2.1	Transitive: unsafe	`+1`	8.39 kB	sindresorhus
npm/resolve-pkg-maps@1.0.0	None	`0`	15 kB	hirokiosame

🚮 Removed packages: npm/@metamask/ppom-validator@0.10.0

View full report↗︎

socket-security · 2024-01-23T11:13:05Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/ppom-validator@0.22.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

jpuri · 2024-01-24T12:49:36Z

@SocketSecurity ignore npm/@metamask/ppom-validator@0.22.0

jpuri · 2024-01-24T16:54:40Z

@metamaskbot update-policies

metamaskbot · 2024-01-24T17:05:42Z

Policies updated

… olu/enable-ppom-on-other-chains-2

…sk/metamask-extension into olu/enable-ppom-on-other-chains-2

jpuri · 2024-01-24T17:40:36Z

@metamaskbot update-policies

metamaskbot · 2024-01-24T17:51:38Z

Policies updated

…sk/metamask-extension into olu/enable-ppom-on-other-chains-2

jpuri · 2024-01-24T18:21:37Z

app/scripts/lib/createStreamSink.js

+class AsyncWritableStream extends Writable {
  constructor(asyncWriteFn, _opts) {
    const opts = { objectMode: true, ..._opts };
    super(opts);


This change was needed to fix a weird lint issue.

jpuri · 2024-01-25T05:26:27Z

@metamaskbot update-policies

jpuri · 2024-01-25T05:28:50Z

ui/components/component-library/icon/icon.types.ts

  Download = 'download',
-  File = 'file',
+  FileIcon = 'file',
  Flask = 'flask',


I renamed the variable to fix lint issue cc @georgewrmarshall

metamaskbot · 2024-01-25T05:37:19Z

Policies updated

metamaskbot · 2024-01-25T06:28:50Z

Builds ready [9cc99f0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (827 ± 22 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	168	119	19	9
		domContentLoaded	9	57	20	12	6
		load	759	938	827	47	22
		domInteractive	9	57	20	12	6

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 41.06 KiB (1.23%)
ui: 0 Bytes (0.00%)
common: 4 Bytes (0.00%)

Redo multichain in another PR

252fe8f

segun added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 23, 2024

segun self-assigned this Jan 23, 2024

segun requested a review from a team as a code owner January 23, 2024 08:11

segun marked this pull request as draft January 23, 2024 08:12

Merge branch 'develop' into olu/enable-ppom-on-other-chains-2

59fcf2c

segun mentioned this pull request Jan 24, 2024

update ppom validator to 0.22.0 #22653

Closed

13 tasks

Merge branch 'develop' into olu/enable-ppom-on-other-chains-2

de70176

Update LavaMoat policies

7cc133c

jpuri added 3 commits January 24, 2024 22:38

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

f563ccc

… olu/enable-ppom-on-other-chains-2

Merge branch 'olu/enable-ppom-on-other-chains-2' of github.com:MetaMa…

4b9d648

…sk/metamask-extension into olu/enable-ppom-on-other-chains-2

Update

e70a5c1

Update LavaMoat policies

019aaf6

jpuri added 2 commits January 24, 2024 23:28

Fix lint issue

b98780c

Merge branch 'olu/enable-ppom-on-other-chains-2' of github.com:MetaMa…

0a87270

…sk/metamask-extension into olu/enable-ppom-on-other-chains-2

jpuri marked this pull request as ready for review January 24, 2024 18:20

jpuri requested review from a team as code owners January 24, 2024 18:20

jpuri reviewed Jan 24, 2024

View reviewed changes

jpuri previously approved these changes Jan 24, 2024

View reviewed changes

Update

67d4f9b

jpuri dismissed their stale review via 67d4f9b January 25, 2024 05:13

jpuri added 2 commits January 25, 2024 10:44

merge

a36a306

Update

c7f4656

jpuri reviewed Jan 25, 2024

View reviewed changes

jpuri previously approved these changes Jan 25, 2024

View reviewed changes

Update LavaMoat policies

9cc99f0

metamaskbot dismissed jpuri’s stale review via 9cc99f0 January 25, 2024 05:37

jpuri approved these changes Jan 25, 2024

View reviewed changes

blackdevelopa approved these changes Jan 25, 2024

View reviewed changes

jpuri merged commit b67f734 into develop Jan 25, 2024

jpuri deleted the olu/enable-ppom-on-other-chains-2 branch January 25, 2024 08:48

github-actions bot locked and limited conversation to collaborators Jan 25, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 25, 2024

metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 25, 2024

Conversation

segun commented Jan 23, 2024

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jan 23, 2024

Uh oh!

socket-security bot commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next steps

Uh oh!

jpuri commented Jan 24, 2024

Uh oh!

jpuri commented Jan 24, 2024

Uh oh!

metamaskbot commented Jan 24, 2024

Uh oh!

jpuri commented Jan 24, 2024

Uh oh!

metamaskbot commented Jan 24, 2024

Uh oh!

jpuri Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

jpuri commented Jan 25, 2024

Uh oh!

jpuri Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Jan 25, 2024

Uh oh!

metamaskbot commented Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

socket-security bot commented Jan 23, 2024 •

edited

Loading

socket-security bot commented Jan 23, 2024 •

edited

Loading