Skip to content

update ppom validator to 0.22.0#22653

Closed
segun wants to merge 3 commits intodevelopfrom
update-ppom-validator-for-multichain
Closed

update ppom validator to 0.22.0#22653
segun wants to merge 3 commits intodevelopfrom
update-ppom-validator-for-multichain

Conversation

@segun
Copy link
Contributor

@segun segun commented Jan 24, 2024

Description

This PR updates package.json with the latest ppom validator new release.

This PR is failing with some weird errors and I feel separating this update from that PR will give a better clarity.

Related issues

Fixes: #22633

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@segun segun requested a review from a team as a code owner January 24, 2024 15:18
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 24, 2024
@socket-security
Copy link

socket-security bot commented Jan 24, 2024

@socket-security
Copy link

socket-security bot commented Jan 24, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@metamask/ppom-validator@0.22.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@segun
Copy link
Contributor Author

segun commented Jan 24, 2024

@SocketSecurity ignore npm/@metamask/ppom-validator@0.22.0

@jpuri
Copy link
Contributor

jpuri commented Jan 24, 2024

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@segun segun requested review from a team as code owners January 24, 2024 17:05
@segun segun closed this Jan 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@HowardBraham HowardBraham deleted the update-ppom-validator-for-multichain branch January 19, 2026 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants