Skip to content

Own and dispose app-level stream subscriptions #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robekl wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Own and dispose app-level stream subscriptions #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions lib/providers/app_state_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ class AppStateProvider extends ChangeNotifier with WidgetsBindingObserver {
// Bluetooth adapter state (on/off)
BluetoothAdapterState _bluetoothAdapterState = BluetoothAdapterState.unknown;
StreamSubscription? _adapterStateSubscription;
StreamSubscription? _connectionSubscription;
StreamSubscription? _gpsStatusSubscription;
StreamSubscription? _gpsPositionSubscription;

// GPS state
GpsStatus _gpsStatus = GpsStatus.permissionDenied;
Expand Down Expand Up @@ -547,7 +550,8 @@ class AppStateProvider extends ChangeNotifier with WidgetsBindingObserver {

// Listen to Bluetooth connection changes
debugLog('[INIT] Setting up BLE connection listener...');
_bluetoothService.connectionStream.listen((status) async {
await _connectionSubscription?.cancel();
_connectionSubscription = _bluetoothService.connectionStream.listen((status) async {
_connectionStatus = status;
if (status == ConnectionStatus.disconnected) {
// Check if this is an unexpected disconnect during active wardriving
Expand All @@ -571,7 +575,8 @@ class AppStateProvider extends ChangeNotifier with WidgetsBindingObserver {

// Listen to GPS changes
debugLog('[INIT] Setting up GPS status listener...');
_gpsService.statusStream.listen((status) {
await _gpsStatusSubscription?.cancel();
_gpsStatusSubscription = _gpsService.statusStream.listen((status) {
final previousStatus = _gpsStatus;
_gpsStatus = status;

Expand All @@ -596,7 +601,8 @@ class AppStateProvider extends ChangeNotifier with WidgetsBindingObserver {
debugLog('[INIT] Initial GPS status: $_gpsStatus');

debugLog('[INIT] Setting up GPS position listener...');
_gpsService.positionStream.listen((position) async {
await _gpsPositionSubscription?.cancel();
_gpsPositionSubscription = _gpsService.positionStream.listen((position) async {
_currentPosition = position;
notifyListeners();

Expand Down Expand Up @@ -4183,6 +4189,9 @@ class AppStateProvider extends ChangeNotifier with WidgetsBindingObserver {
_isDisposed = true;
WidgetsBinding.instance.removeObserver(this);
_adapterStateSubscription?.cancel();
_connectionSubscription?.cancel();
_gpsStatusSubscription?.cancel();
_gpsPositionSubscription?.cancel();
_logRxDataSubscription?.cancel();
_noiseFloorSubscription?.cancel();
_batterySubscription?.cancel();
Expand Down