Own and dispose app-level stream subscriptions#7
Open
robekl wants to merge 1 commit intoMeshMapper:devfrom
Open
Own and dispose app-level stream subscriptions#7robekl wants to merge 1 commit intoMeshMapper:devfrom
robekl wants to merge 1 commit intoMeshMapper:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Owns and disposes long-lived
AppStateProviderstream subscriptions to prevent leaked listeners and duplicate callbacks across provider lifecycle events.Problem
AppStateProvidercreated listeners for:connectionStreamstatusStreampositionStreambut did not keep/cancel those subscriptions explicitly in
dispose().That can cause lingering listeners and repeated state updates after re-init/hot-reload/provider recreation.
Changes
_connectionSubscription_gpsStatusSubscription_gpsPositionSubscription_initialize():dispose():Why this works
All app-level stream listeners are now lifecycle-owned by the provider instance and deterministically cancelled at teardown.