-
Notifications
You must be signed in to change notification settings - Fork 7
Huge Update, Added Multilingual Support and Rewrote the Menu System #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…l 5 boss works propperly now. Did not make any changes to fix this blitch, fixed itself. Sarcastic messages when you get killed are back. Changed some of the sounds. Now using the DFSpeech/DLG method of speaking text, found at https://github.com/cartertemm?tab=repositories. Took out the old menu system and replaced it with m_pro, found at https://github.com/cartertemm?tab=repositories. Added multilingual support. New language: Spanish, (Google Translated). Readded enter sounds for the menus.
Menelion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this pull request! First of all, it's great, and second, it's very much appreciated! I left some tiny comments, would you please look at them? And then I'll merge. Thanks.
data/language_manager.bgt
Outdated
| 8) The more important: To show the messages into your game, call the array voice[position], where "position" is the number of the message. For example, voice[1]; | ||
|
|
||
|
|
||
| Descripci�n en espa�ol: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh-oh, something severely broke Unicode here... if it was Unicode in the beginning. BTW, I even don't know whether BGT supports unicode properly (from my vague memories, it seems not).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't even realize until you pointed it out. I don't know Spanish myself, and only kept the Spanish text because it was already there.
| menu_items[i]=language_files[i]; // Adding new item. A�adimos un nuevo objeto | ||
| wait(5); // Like to don't overload the CPUE. Bueno para no sobrecargar la CPU | ||
| } | ||
| //tts_voice speech; // Voice object. Objeto de voz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that no longer necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the coughing sound in the learn game sounds menu no longer necessary? I'm not sure; I kept a lot of the sounds there so that people wouldn't have to wonder what the sound meant. If you meant the above comment about the tts voice object, I just left the comments in place. I felt it was unnecessary, but I didn't think it would hurt anything to leave it.
| lgs.add_item(voice[132],"sounds/coughing.wav"); | ||
| lgs.add_item(voice[133],"sounds/endoflevel.wav"); | ||
| lgs.run(voice[134]); | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure which line you're referring to; I'm still getting used to Github so there are some bits of it that confuse me. If you're referring to mode=m;, I'm not sure to be honest. This file is the speech include that comes with mpro, so I didn't look at it more than I really needed to.
| mode=m; | ||
| } | ||
| //I think that's it. If you need anything else implemented, let me know. | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
| 98=excursiones forestales | ||
| 99=retumba en la oscuridad | ||
| 100=Una tierra de maravillas de invierno, llena de enemigos ... | ||
| 101=El río Vile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vile means evil, malicious. I'd say, El río funesto (o desastroso)
| 128=roca te golpea | ||
| 129=ataque enemigo completamente absorbido por la armadura | ||
| 130=bola de fuego | ||
| 131=Fireball te golpea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¿Bola de fuego?
| 131=Fireball te golpea | ||
| 132=estás herido | ||
| 133=fin de nivel | ||
| 134=Use las teclas de flecha hacia arriba y hacia abajo para navegar, y presione enter para seleccionar. No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no newline...
|
|
||
| h2. Changes made by Brogar2000 on 04/16/2020 | ||
| * Made a data folder and moved a few files to it. Hopefully I can move more files over to it at a later date. | ||
| * Renamed ss.bgt to game.bgt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍 👍
| * Took out the old menu system and replaced it with m_pro, made by http://masonasons.me and found at https://github.com/cartertemm?tab=repositories | ||
| * Battle Zone now makes use of dialogues. To scroll through dialogues, just press the enter key. | ||
| * Battle Zone now has support for multiple languages. To make a new language, go into the languages folder. You can use the English file as a template. Remember not to add a file extention to your language file, or else the game will read out .txt at the end of the language name. | ||
| * New language: Spanish, (Google Translated). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, that's why! For a Google translation it's not bad at all!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. If someone who knows Spanish can fix the translation errors when I submit the second pull request, that would be wonderful, as I don't know Spanish very well. I only know English.
…ce code can download the build version and play it.
|
@brogar2000 Are you sure it's a good idea to store built files in the repo itself? Is there a way to pack the files into a zip or an installer and upload them to Github releases? |
Co-authored-by: Andre Polykanine <ap@oire.me>
I've made a lot of updates, most notably multilingual support and changing the menus to use MPro. This means that not only can we use letter navigation in the menus, but we can also use our preferred screen reader with the game. There are other changes as well, such as the level 5 boss working and changes to some of the sounds.