Skip to content

Extended To Allow "Nil" As Default Values + Added Missing Camera Deactavation Logic For The AttachToPart Property. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BlackJackiee wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Extended To Allow "Nil" As Default Values + Added Missing Camera Deactavation Logic For The AttachToPart Property. #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd21725
Add Missing Camera Deactivation On AttachToPart Removed
BlackJackiee Dec 6, 2025
9ac2d82
Extended MoonProperties To Support "Nil" Being Set As A Default Value.
BlackJackiee Dec 6, 2025
ea25930
Added An Extra Type To Not Mess Up Pure "MoonProperties" Usage Types
BlackJackiee Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Moonlite/Specials.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,10 @@ Specials.Camera = {
setCameraActive(work, camera, true)
else
work._cameraAttachToPart = nil

if not work._cameraLookAtPart then
setCameraActive(work, camera, false)
end
end
end,
}),
Expand Down
4 changes: 4 additions & 0 deletions Moonlite/Types.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ export type MoonProperties = {
[string]: any,
}

export type MoonPropertiesNil = {
[string]: { Value: any },
}

export type MoonFrameBuffer = {
[Instance]: {
[number]: MoonProperties,
Expand Down
9 changes: 5 additions & 4 deletions Moonlite/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ type MoonKeyframe = Types.MoonKeyframe
type MoonProperty = Types.MoonProperty
type MoonJointInfo = Types.MoonJointInfo
type MoonProperties = Types.MoonProperties
type MoonPropertiesNil = Types.MoonPropertiesNil
type MoonFrameBuffer = Types.MoonFrameBuffer
type MoonElementLocks = Types.MoonElementLocks
type MoonKeyframePack = Types.MoonKeyframePack
Expand Down Expand Up @@ -80,7 +81,7 @@ export type MoonTrack = typeof(setmetatable({} :: {

local PlayingTracks = {} :: {
[MoonTrack]: {
[Instance]: MoonProperties,
[Instance]: MoonPropertiesNil,
},
}

Expand Down Expand Up @@ -675,8 +676,8 @@ local function restoreTrack(self: MoonTrack)

if self.RestoreDefaults then
for instance, props in defaults do
for name, value in props do
setPropValue(self, instance, name, value)
for name, valueTbl in props do
setPropValue(self, instance, name, valueTbl.Value)
end
end
end
Expand Down Expand Up @@ -925,7 +926,7 @@ function MoonTrack.Play(self: MoonTrack)
for name in frames[0] do
local success, value = getPropValue(self, instance, name)
if success then
defaults[name] = value
defaults[name] = { Value = value }
end
end
end
Expand Down