Extended To Allow "Nil" As Default Values + Added Missing Camera Deactavation Logic For The AttachToPart Property.#22
Open
BlackJackiee wants to merge 3 commits intoMaximumADHD:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended MoonProperties To Allow "Nil" To Be Set As A Default Value + Added Missing Camera Deactavation Logic For The "AttachToPart" Property.
Nil Issue:
If an animation property is nil before the animation plays, this value won't be tracked correctly since "Defaults[property] = nil" won't be picked up when restoring properties to default.
AttachToPart Issue:
Unlike the "LookAtPart" specials prop handler, when AttachToPart is set nil, the camera wasn't being deactivated; leading to the camera being stuck after an animation is stopped.