gnss: add error handling to filesystem iteration in get_available_geoids#383
Closed
gnss: add error handling to filesystem iteration in get_available_geoids#383
Conversation
Merged
Co-authored-by: michalpelka <3209244+michalpelka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on Proj integration implementation
gnss: add error handling to filesystem iteration in get_available_geoids
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_available_geoidsiterated candidate directories usingstd::filesystem::directory_iteratorwithout any error handling, causing uncaughtstd::filesystem::filesystem_errorexceptions on permission errors or broken symlinks — crashing the app at startup.Changes
core/src/gnss.cpp— replace all throwing filesystem calls withstd::error_codeoverloads:exists(path, ec)— avoids throw on unresolvable symlinksdirectory_iterator(path, ec)— logs and skips the candidate path if it cannot be openeddir_it.increment(ec)— logs and breaks the inner loop if a mid-iteration error occursentry.is_regular_file(ec)— silently skips entries that cannot be stat'dErrors are reported to
std::cerr; unreadable paths are skipped without interrupting the search over remaining candidates.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.