Merged
Conversation
Contributor
|
Seems like there's some overlap in what this and #126 are trying to solve. For consistency, feels like it would be best to have the single string argument like 126's
Shouldn't require regex. Can probably just split on operator and trim both sides, or something like that. 😄 |
Contributor
Author
|
if #133 get merged before this ill add a commit to remove the unused arguments (multiworld, state, player) |
Contributor
Author
silasary
approved these changes
Feb 6, 2025
axxroytovu
added a commit
to axxroytovu/AP_Manual_world
that referenced
this pull request
Apr 4, 2025
Fixed hook type hints Added `==` as valid option to match ManualForArchipelago#130 syntax
FuzzyGamesOn
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pr adds a require function that let the dev compare the yaml value of an option using any of the following:
==/=!=><>=<=and a value that get converted to wathever the compared option type support
in the format {YamlCompare(OptionName, Symbol, value to compare against)}
ex:
{YamlCompare(Example_Range > 5)}it works like this:
convert_string_to_typeusing whatever type that option supportsI might try and do some trickery to let user forget theadded jan 25,in the function aka have only one argument but that would require some regex that ill only create if we would prefer it that way