-
Notifications
You must be signed in to change notification settings - Fork 21
Yaml option expansion #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Yaml option expansion #126
Conversation
Normalized ":" equality for all option types Removed imports from data and now reference multiworld/world data directly
is_location_enabled and is_item_enabled function input types were wrong and confusing Split lambdas into two stages to prevent infinite recursion
silasary
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choices should also use =, not :
|
Easy enough change. I kept |
silasary
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're supporting >= and <=, we should probably also support !=?
|
It does already, but the format is "!option=value". Should be easy enough to also support "option!=value" as well. |
|
Yeah. Supporting both will lead to less support requests :D |
Fixed hook type hints Added `==` as valid option to match ManualForArchipelago#130 syntax
|
At a glance, looks like this is just waiting on the resolve_yaml / manualobject_enabled adjustment. Skimmed over and looks good, will circle back to review more. |
|
Im currently working on fixing the issue this PR was waiting on and on the reason why this PR fails the Fuzz tests
If any of those changes are not something we want I can always revert them |
Still needs cleanup so I'm leaving this as draft for now.
What does this PR do?
yaml_optiondefinitionsyaml_optionto check range & choice options:"option>10","option<10","option=10"and"!option=10"all properly check against a range option"option:choice"properly checks against a choice option