Merged
Conversation
Don't know if it works, let's try :-) 'windows-latest` currently means Windows Server 2022 (https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/)
Hope this might fix "Error installing rake" errors. - https://github.com/ruby/setup-ruby#windows has some indications Windows needs particular versions of bundler to work well, and IIUC setup-ruby should already install bundler, so rely on that. - We do need rake but it's a kubeclient.gemspec dependency that `bundle install` should cover, avoid a global install with `gem`.
Needed on Windows: https://github.com/tzinfo/tzinfo/wiki/Resolving-TZInfo::DataSourceNotFound-Errors tzinfo is required by (at least) openid_connect gem, which is an "optional" dependency for kubeclient — users are supposed to bring it themselves if they use 'oidc' auth — so making tzinfo-data a dev dependency.
Collaborator
Author
|
Merging despite #569 failures because more CI is always better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #553