CI: run on windows? by cben · Pull Request #553 · ManageIQ/kubeclient

cben · 2022-03-23T07:59:44Z

Don't know if it works, let's try :-)

'windows-latest` currently means Windows Server 2022
(https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/)

cben · 2022-03-23T08:03:00Z

🔴 ruby 2.5 to 3.0 fail with:

Run gem install rake bundler
ERROR:  Error installing rake:
	"rake" from rake conflicts with C:/hostedtoolcache/windows/Ruby/3.0.3/x64/bin/rake
Successfully installed bundler-2.3.9
1 gem installed

🔴 ruby 3.1, ruby-head, truffleruby-head pass bundle install 🎉 but fail with:

C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/data_source.rb:159:in `rescue in create_default_data_source': No source of timezone data could be found. (TZInfo::DataSourceNotFound)
Please refer to https://tzinfo.github.io/datasourcenotfound for help resolving this error.
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/data_source.rb:156:in `create_default_data_source'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/data_source.rb:55:in `block in get'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/data_source.rb:54:in `synchronize'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/data_source.rb:54:in `get'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/timezone.rb:235:in `data_source'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/timezone.rb:158:in `all_identifiers'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/timezone.rb:152:in `all'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object/user_info.rb:30:in `<class:UserInfo>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object/user_info.rb:3:in `<class:ResponseObject>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object/user_info.rb:2:in `<module:OpenIDConnect>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object/user_info.rb:1:in `<top (required)>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object.rb:7:in `require'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object.rb:7:in `block in <top (required)>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object.rb:6:in `each'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object.rb:6:in `<top (required)>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/connect_object.rb:52:in `require'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/connect_object.rb:52:in `<top (required)>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect.rb:101:in `require'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect.rb:101:in `<top (required)>'
	from D:/a/kubeclient/kubeclient/test/test_oidc_auth_provider.rb:2:in `require'
	from D:/a/kubeclient/kubeclient/test/test_oidc_auth_provider.rb:2:in `<top (required)>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:17:in `require'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:17:in `block in <main>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:5:in `select'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:5:in `<main>'
C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/data_sources/zoneinfo_data_source.rb:232:in `initialize': None of the paths included in TZInfo::DataSources::ZoneinfoDataSource.search_path are valid zoneinfo directories. (TZInfo::DataSources::ZoneinfoDirectoryNotFound)
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/data_source.rb:157:in `new'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/data_source.rb:157:in `create_default_data_source'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/data_source.rb:55:in `block in get'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/data_source.rb:54:in `synchronize'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/data_source.rb:54:in `get'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/timezone.rb:235:in `data_source'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/timezone.rb:158:in `all_identifiers'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/tzinfo-2.0.4/lib/tzinfo/timezone.rb:152:in `all'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object/user_info.rb:30:in `<class:UserInfo>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object/user_info.rb:3:in `<class:ResponseObject>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object/user_info.rb:2:in `<module:OpenIDConnect>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object/user_info.rb:1:in `<top (required)>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object.rb:7:in `require'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object.rb:7:in `block in <top (required)>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object.rb:6:in `each'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/response_object.rb:6:in `<top (required)>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/connect_object.rb:52:in `require'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect/connect_object.rb:52:in `<top (required)>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect.rb:101:in `require'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/openid_connect-1.3.0/lib/openid_connect.rb:101:in `<top (required)>'
	from D:/a/kubeclient/kubeclient/test/test_oidc_auth_provider.rb:2:in `require'
	from D:/a/kubeclient/kubeclient/test/test_oidc_auth_provider.rb:2:in `<top (required)>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:17:in `require'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:17:in `block in <main>'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:5:in `select'
	from C:/hostedtoolcache/windows/Ruby/3.1.1/x64/lib/ruby/gems/3.1.0/gems/rake-12.3.3/lib/rake/rake_test_loader.rb:5:in `<main>'
rake aborted!

cben · 2022-07-24T19:38:35Z

Yay, windows now on parity with other platforms, all CRuby versions actually run the tests, and all passed except #569 🎉

(Well, except truffleruby-head which apparently has no windows builds? anyway that's not a blocker.)

cben · 2022-07-25T08:28:08Z

Force-pushed to use same rebased commits as #570.

now macos 2.5 keeps timing out 😕
It's not always at same moment — attempt 1 got stuck after test_get_from_json_oapi_v1, attempt 2 got stuck after test_timeouts_open, attempt 3 after test_irregular_names.

There is a warning that might or might not be related 🤷 :

Your RubyGems version (2.7.6.3) has a bug that prevents required_ruby_version from working for Bundler. Any scripts that use gem install bundler will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running gem update --system 3.2.3

I guess it's time to drop EOL Ruby 2.5 (and 2.6?) on master branch?

cben · 2022-09-02T14:33:35Z

https://github.com/ruby/truffleruby-dev-builder/releases/latest has no windows build.
Trying to exclude it...

This ubuntu ruby 2.5 failure is somewhat interesting, must be a low-probability flake:

  1) Failure:
RetryTest#test_can_watch_watches [/home/runner/work/kubeclient/kubeclient/test/test_informer.rb:115]:
Expected: [["ADDED"], ["ADDED"]]
  Actual: [[], ["ADDED"]]

but unrelated to the addition of windows CI.

Hope this might fix "Error installing rake" errors. - https://github.com/ruby/setup-ruby#windows has some indications Windows needs particular versions of bundler to work well, and IIUC setup-ruby should already install bundler, so rely on that. - We do need rake but it's a kubeclient.gemspec dependency that `bundle install` should cover, avoid a global install with `gem`.

Needed on Windows: https://github.com/tzinfo/tzinfo/wiki/Resolving-TZInfo::DataSourceNotFound-Errors tzinfo is required by (at least) openid_connect gem, which is an "optional" dependency for kubeclient — users are supposed to bring it themselves if they use 'oidc' auth — so making tzinfo-data a dev dependency.

Personally, I wish we were using: Style::TrailingCommaInHashLiteral: EnforcedStyleForMultiline: consistent_comma but that'd require 49 fixes, too much noise.

Don't know if it works, let's try :-) 'windows-latest` currently means Windows Server 2022 (https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/)

cben · 2022-09-02T15:41:51Z

Bah, broke something in github actions file.

I'm tempted to just leave non-existant (windows, truffleruby) combination in, but I think the rubocop job was already broken (it did not use os_and_command) 🙄 so need to debug anyway...

cben mentioned this pull request Mar 23, 2022

[v4.y] Load cluster ca certificates using OpenSSL::X509::Store#add_file #552

Merged

cben closed this Jul 24, 2022

cben reopened this Jul 24, 2022

cben mentioned this pull request Jul 24, 2022

[v4.y] CI: run on windows #570

Merged

cben force-pushed the ci-windows branch 2 times, most recently from e887fe4 to 96be379 Compare July 25, 2022 06:31

cben closed this Aug 29, 2022

cben reopened this Aug 29, 2022

cben force-pushed the ci-windows branch 4 times, most recently from 5683753 to 6dd4df1 Compare September 2, 2022 15:12

cben added 2 commits September 2, 2022 18:13

cben force-pushed the ci-windows branch from 6dd4df1 to 50f2d57 Compare September 2, 2022 15:17

cben added 2 commits September 2, 2022 18:36

Fix rubocop warnings

d9672bd

Personally, I wish we were using: Style::TrailingCommaInHashLiteral: EnforcedStyleForMultiline: consistent_comma but that'd require 49 fixes, too much noise.

CI: run on windows

e105ee2

Don't know if it works, let's try :-) 'windows-latest` currently means Windows Server 2022 (https://github.blog/changelog/2022-01-11-github-actions-jobs-running-on-windows-latest-are-now-running-on-windows-server-2022/)

cben force-pushed the ci-windows branch from 7bea071 to e105ee2 Compare September 2, 2022 15:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: run on windows?#553

CI: run on windows?#553
cben wants to merge 4 commits intoManageIQ:masterfrom
cben:ci-windows

cben commented Mar 23, 2022

Uh oh!

cben commented Mar 23, 2022

Uh oh!

cben commented Jul 24, 2022 •

edited

Loading

Uh oh!

cben commented Jul 25, 2022

Uh oh!

cben commented Sep 2, 2022

Uh oh!

cben commented Sep 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

cben commented Mar 23, 2022

Uh oh!

cben commented Mar 23, 2022

Uh oh!

cben commented Jul 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cben commented Jul 25, 2022

Uh oh!

cben commented Sep 2, 2022

Uh oh!

cben commented Sep 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

cben commented Jul 24, 2022 •

edited

Loading