Fix #320 - Corrections to step-index fiber mode solver#321
Open
ovanvincq wants to merge 2 commits intoLupoLab:masterfrom
Open
Fix #320 - Corrections to step-index fiber mode solver#321ovanvincq wants to merge 2 commits intoLupoLab:masterfrom
ovanvincq wants to merge 2 commits intoLupoLab:masterfrom
Conversation
ovanvincq
commented
Mar 21, 2023
ovanvincq
commented
- TE and TM modes were initially reversed, they have been exchanged.
- Add a workaround to remove the discontinuities found by Roots.jl in findneff function.
Add a workaround to remove the discontinuities found by Roots.jl in findneff function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.