Skip to content

Fix #320 - Corrections to step-index fiber mode solver #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ovanvincq wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix #320 - Corrections to step-index fiber mode solver #321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0c9a62
Exchange TE and TM modes
ovanvincq Mar 21, 2023
7b4ec87
Fix findneff function
ovanvincq Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/StepIndexFibre.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,11 @@ function char_HE(radius, k0, ncore, nclad, n, neff)
char_LHS(n, u) - char_RHS(ncore, nclad, n, w) + R(ncore, nclad, n, u, w, neff)
end

function char_TE(radius, k0, ncore, nclad, neff)
function char_TM(radius, k0, ncore, nclad, neff)
char_HE(radius, k0, ncore, nclad, 0, neff)
end

function char_TM(radius, k0, ncore, nclad, neff)
function char_TE(radius, k0, ncore, nclad, neff)
char_EH(radius, k0, ncore, nclad, 0, neff)
end

Expand Down Expand Up @@ -202,6 +202,10 @@ end
function findneff(radius, k0, ncore, nclad, n, m, mode=:HE, pts=100)
char = make_char(radius, k0, ncore, nclad, n, mode)
roots = find_zeros(char, nclad, ncore, no_pts=pts)
r=[nclad;roots]
t1=char.(roots-diff(r)/3*2)
t2=char.(roots-diff(r)/3)
roots=roots[abs.(t2).<abs.(t1)]
roots[end - (m - 1)]
end

Expand Down