feat: Standardize SquadAuto

[mbergen]

Summary

Replace old, unmaintainable SquadAuto with a version that is hopefully a bit easier to maintain.

How did you test this change?

dev

[mbergen]

This is an initial version of a (potentially standardized) SquadAuto, without TimelineAuto.
It is not yet feature complete, but should already work on wikis using basic setups (see also various TODO comments).
The idea would be to let other wikis test this version, and add missing features only if necessary.

Once all wikis are on this version, there are also further simplifications possible (e.g. merging SquadAutoPerson and SquadPerson types)

[hjpalpha]

spaces --> tabs pls ;)

[hjpalpha]

probably oos, but long term we probably should use the model for the transfer queries

overall, seems reasonable on phone

[ElectricalBoy]

some strings use " and others use '; we should use ' to stay consistent with the rest of Lua files

[mbergen]

Marking this as ready for review.
It does not use the new Role modules yet, but i'd argue it would only make sense to use them here once they are used in Transfers.

Idea is still to roll out wiki-by-wiki and fix (or implement) necessary things.

[mbergen]

Test page with comparison new (left) vs old squadauto:
https://liquipedia.net/ageofempires/User:SyntacticSalt/ModuleTests

[ElectricalBoy]

use ConditionUtil.anyOf maybe?

[mbergen]

In what way? It's not a list of values, but a list of columns.
Unless you mean to create an array of columns, and then use anyOf for the list of teams

[mbergen]

Suggested change

	Array.forEach(self.config.teams, function (templatename)
	conditions:add{
	Condition.Node(Condition.ColumnName('fromteamtemplate'), Comparator.eq, templatename),
	Condition.Node(Condition.ColumnName('extradata_fromteamsectemplate'), Comparator.eq, templatename),
	Condition.Node(Condition.ColumnName('toteamtemplate'), Comparator.eq, templatename),
	Condition.Node(Condition.ColumnName('extradata_toteamsectemplate'), Comparator.eq, templatename)
	}
	end)
	conditions:add{
	Condition.Util.anyOf(Condition.ColumnName('fromteamtemplate'), self.config.teams),
	Condition.Util.anyOf(Condition.ColumnName('extradata_fromteamsectemplate'), self.config.teams),
	Condition.Util.anyOf(Condition.ColumnName('toteamtemplate'), self.config.teams),
	Condition.Util.anyOf(Condition.ColumnName('extradata_toteamsectemplate'), self.config.teams),
	}

like this?
I'd prefer the current way, as it is IMO easier to digest and also leads to a simpler rendered condition.

[ElectricalBoy]

Suggested change

	Condition.Tree(BooleanOperator.any):add{
	Condition.Node(Condition.ColumnName('date'), Comparator.gt, date),
	}
	Condition.Node(Condition.ColumnName('date'), Comparator.gt, date),

maybe use Comparator.ge?

[mbergen]

That wouldn't work (at least not on it's own) as you'd get the transfer of the person leaving, whereas we are interested in the next transfer of the person joining.
Would need to also check for lt objectid (if eq date) or something.

[hjpalpha]

on mobile, so could be easily wrong, but does this kick the Squad/rank stuff?
if yes we can expect the wikis that use it to cry if this goes live

[mbergen]

on mobile, so could be easily wrong, but does this kick the Squad/rank stuff?
if yes we can expect the wikis that use it to cry if this goes live

It's not supposed to kick it, just not implemented yet.