Fix: Add headless config to AppLauncher in export_env_for_envhub#35
Open
Fix: Add headless config to AppLauncher in export_env_for_envhub#35
Conversation
Closes #29 - Add 'headless' and 'enable_cameras' to default config in _parse_config - Pass headless=cfg.headless to AppLauncher to prevent implicit override - Fixes RuntimeError when running on headless servers with NO_GUI_OR_RENDERING
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29
Problem
In
export_env_for_envhub,AppLauncheris initialized without theheadlessparameter, causingcfg.headlessto be implicitly overwritten by AppLauncher defaults. This results in errors when running on headless servers:Solution
headless: Trueandenable_cameras: Falseto default config in_parse_configheadless=cfg.headlesstoAppLauncherinitializationChanges
lw_benchhub/utils/envhub_utils.py: Updatedexport_env_for_envhubfunctionTesting
On a headless server, running
export_env_for_envhubshould no longer raise RuntimeError.