feat(dashboard): add settings API contract#363
Open
powerfulDev-cloud wants to merge 1 commit intoLight-Heart-Labs:mainfrom
Open
feat(dashboard): add settings API contract#363powerfulDev-cloud wants to merge 1 commit intoLight-Heart-Labs:mainfrom
powerfulDev-cloud wants to merge 1 commit intoLight-Heart-Labs:mainfrom
Conversation
Lightheartdevs
requested changes
Mar 18, 2026
Collaborator
Lightheartdevs
left a comment
There was a problem hiding this comment.
Review: REQUEST CHANGES — Hard conflict with PR #364
Blocking: Incompatible /api/settings implementations
PR #363 adds GET /api/settings in main.py with a rich payload (version, services, GPU, model, updates, hostname). PR #364 adds GET /api/settings in routers/runtime.py with a slimmer payload (version, tier, uptime, storage). Different response shapes, different locations, different tests. Cannot both merge.
Recommendation: Merge the richer payload from #363 into the routers/runtime.py location from #364. Both PRs also have near-identical _format_uptime helpers.
Blocking: Verify triggerUpdate exists
Settings.jsx imports triggerUpdate from ../hooks/useVersion, but no changes to that hook are in the diff. If this function doesn't exist on the target branch, the build breaks.
Non-blocking:
_read_version_statesilently returns("0.0.0", {})on JSON parse failure — addlogger.warningsocket.gethostname()exposed in API — unnecessary since frontend already haswindow.location.hostname
🤖 Reviewed with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.