Pr 03 dashboard settings update ux#353
Open
eva57gr wants to merge 3 commits intoLight-Heart-Labs:mainfrom
Open
Pr 03 dashboard settings update ux#353eva57gr wants to merge 3 commits intoLight-Heart-Labs:mainfrom
eva57gr wants to merge 3 commits intoLight-Heart-Labs:mainfrom
Conversation
Lightheartdevs
requested changes
Mar 18, 2026
Collaborator
Lightheartdevs
left a comment
There was a problem hiding this comment.
Review: REQUEST CHANGES
Blocking: script_path leaked in API response
/api/update/readiness returns the absolute filesystem path of the update script. The frontend never uses this value. Remove it from the response — leaking internal paths is unnecessary information disclosure.
Blocking: _collect_rollback_state has no error handling
Path.glob on a nonexistent backups directory will raise. Since this is an I/O boundary, add a targeted FileNotFoundError catch returning {"available": False, "backup_count": 0}.
Blocking: Coordinate with PR #363
Both PRs substantially modify Settings.jsx, updates.py, README.md, and test files. Need a defined merge order — the second to merge will require a non-trivial rebase.
Non-blocking:
- Version-state spread-merge pattern repeated 3 times with subtly different shapes — consider a normalizer function
- "Refresh this page in a minute" after update — no auto-refresh or polling, users could miss the window
🤖 Reviewed with Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.