Skip to content

Pr 03 dashboard settings update ux#353

Open
eva57gr wants to merge 3 commits intoLight-Heart-Labs:mainfrom
eva57gr:pr-03-dashboard-settings-update-ux
Open

Pr 03 dashboard settings update ux#353
eva57gr wants to merge 3 commits intoLight-Heart-Labs:mainfrom
eva57gr:pr-03-dashboard-settings-update-ux

Conversation

@eva57gr
Copy link
Contributor

@eva57gr eva57gr commented Mar 17, 2026

No description provided.

Copy link
Collaborator

@Lightheartdevs Lightheartdevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: REQUEST CHANGES

Blocking: script_path leaked in API response

/api/update/readiness returns the absolute filesystem path of the update script. The frontend never uses this value. Remove it from the response — leaking internal paths is unnecessary information disclosure.

Blocking: _collect_rollback_state has no error handling

Path.glob on a nonexistent backups directory will raise. Since this is an I/O boundary, add a targeted FileNotFoundError catch returning {"available": False, "backup_count": 0}.

Blocking: Coordinate with PR #363

Both PRs substantially modify Settings.jsx, updates.py, README.md, and test files. Need a defined merge order — the second to merge will require a non-trivial rebase.

Non-blocking:

  • Version-state spread-merge pattern repeated 3 times with subtly different shapes — consider a normalizer function
  • "Refresh this page in a minute" after update — no auto-refresh or polling, users could miss the window

🤖 Reviewed with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants