Retrieve appflags from app.elf and use it for derivation#618
Merged
nroggeman-ledger merged 2 commits intomasterfrom Dec 4, 2025
Merged
Retrieve appflags from app.elf and use it for derivation#618nroggeman-ledger merged 2 commits intomasterfrom
nroggeman-ledger merged 2 commits intomasterfrom
Conversation
79242f5 to
155e3c7
Compare
Contributor
iartemov-ledger
left a comment
There was a problem hiding this comment.
1st round, as it is late evening.
155e3c7 to
4ee5dc3
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #618 +/- ##
==========================================
- Coverage 40.94% 40.71% -0.23%
==========================================
Files 132 132
Lines 14106 14215 +109
Branches 1256 1275 +19
==========================================
+ Hits 5775 5787 +12
- Misses 7951 8046 +95
- Partials 380 382 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4ee5dc3 to
cf1f5a9
Compare
a0c9ea1 to
17658fa
Compare
17658fa to
f575980
Compare
f575980 to
9401842
Compare
9401842 to
4d03434
Compare
Contributor
iartemov-ledger
left a comment
There was a problem hiding this comment.
Works for BTC !
I'd real like to have the real exception value for the wrong path checking, 0x4212 in this case. Why to wait a new PR. We're not obliged to change everything, but can correct values gradually.
6 tasks
8bfd087 to
2d2a1e6
Compare
iartemov-ledger
previously approved these changes
Dec 4, 2025
Contributor
iartemov-ledger
left a comment
There was a problem hiding this comment.
I've tested:
- attempt to derive at root-level without HAVE_APPLICATION_FLAG_DERIVE_MASTER (future test_get_extended_pubkey_non_standard BTC test)
- attempt to BIP32 derivation with a path different from PATH_APP_LOAD_PARAMS (future test_get_extended_pubkey_non_standard BTC test)
- attempt to SLIP21 derivation with a path different from PATH_SLIP21_APP_LOAD_PARAMS (an app modification is required)
- attempt to use a curve different from CURVE_APP_LOAD_PARAMS (an app modification is required)
2d2a1e6 to
e62afb2
Compare
iartemov-ledger
previously approved these changes
Dec 4, 2025
e62afb2 to
5e565d2
Compare
5e565d2 to
ff54461
Compare
iartemov-ledger
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to be able to support retrieving appflags from app.elf and use it for derivation.
It is linked to https://ledgerhq.atlassian.net/browse/B2CA-2435
Related PRs:
ledger.app_flagssection extraction from app.elf ledgered#60