Put also app-flags in app.elf to be retrievable by Speculos#1344
Merged
nroggeman-ledger merged 1 commit intomasterfrom Dec 4, 2025
Merged
Put also app-flags in app.elf to be retrievable by Speculos#1344nroggeman-ledger merged 1 commit intomasterfrom
nroggeman-ledger merged 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1344 +/- ##
=======================================
Coverage 78.60% 78.60%
=======================================
Files 42 42
Lines 4571 4571
Branches 669 669
=======================================
Hits 3593 3593
Misses 928 928
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iartemov-ledger
approved these changes
Dec 3, 2025
nroggeman-ledger
force-pushed
the
put-appflags-also-in-install-params
branch
2 times, most recently
from
28b80c2 to
f16e339
Compare
nroggeman-ledger
changed the title
Contributor
iartemov-ledger
left a comment
iartemov-ledger
left a comment
There was a problem hiding this comment.
2 minor comments.
nroggeman-ledger
force-pushed
the
put-appflags-also-in-install-params
branch
from
f16e339 to
3c213eb
Compare
nroggeman-ledger
force-pushed
the
put-appflags-also-in-install-params
branch
from
3c213eb to
ca26133
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to make app_flags also visible in Speculos, to improve emulation of Bolos.
The first targeted usage is the HAVE_APPLICATION_FLAG_DERIVE_MASTER flag, to limit derivation
It is linked to https://ledgerhq.atlassian.net/browse/B2CA-2435
Related PRs:
ledger.app_flagssection extraction from app.elf ledgered#60Changes include
Auto cherry-pick in API_LEVEL
If requested to port the commits from this PR on a dedicated API_LEVEL branch,
select the targeted one(s), or add new references if not listed:
[x] TARGET_API_LEVEL: API_LEVEL_25
This will only create the PR with cherry-picks, ready to be reviewed and merged.
Remember: