Revert "Fix submodule configuration for RobotStateMachine"#70
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts a previous submodule configuration change by removing the RobotStateMachine submodule and updating CI workflow configurations to use standard GitHub tokens instead of custom organization secrets.
- Removed RobotStateMachine as a tracked git submodule
- Downgraded actions/checkout from v5 to v3 in CI workflow
- Replaced custom ORGA_GH_TOKEN with default github.token for improved maintainability
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .gitmodules | Removed RobotStateMachine submodule configuration entry |
| src/RobotStateMachine | Updated subproject commit reference (inconsistent with submodule removal) |
| .github/workflows/ros-ci.yml | Downgraded checkout action and switched to default GitHub token |
Comments suppressed due to low confidence (1)
src/RobotStateMachine:1
- The submodule entry still exists with a new commit reference despite the removal of its configuration in .gitmodules. If RobotStateMachine is truly no longer used as stated in the PR description, this directory should be completely removed from git tracking using
git rm -r src/RobotStateMachine.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #66
Remove [RobotStateMachine @ 911d58d] as it is no longer used.
This pull request mainly updates CI configuration and submodule management for the repository. The most significant changes are grouped below by theme.
CI Workflow Updates:
actions/checkoutGitHub Action from version 5 to version 3 in.github/workflows/ros-ci.ymlto address compatibility or stability concerns.import-tokenforros-tooling/action-ros-cifrom a custom secret (ORGA_GH_TOKEN) to the defaultgithub.token, improving maintainability and reducing secret management overhead.Submodule Management:
RobotStateMachinesubmodule from.gitmodules, indicating it is no longer tracked as a submodule in the repository.src/RobotStateMachineto point to a new commit, reflecting either a manual update or the removal of the submodule.