Fix an edge case where $1DFB commands were not executing while paused#488
Open
KungFuFurby wants to merge 2 commits intomasterfrom
Open
Fix an edge case where $1DFB commands were not executing while paused#488KungFuFurby wants to merge 2 commits intomasterfrom
KungFuFurby wants to merge 2 commits intomasterfrom
Conversation
The !PauseMusic check has been moved. $1DFB commands will now be processed, but won't appear to take effect until after the unpause SFX is played. Music ticks still won't be processed other than initializing a new song as needed. This commit closes #487.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The !PauseMusic check has been moved. $1DFB commands will now be processed, but won't appear to take effect until after the unpause SFX is played. Music ticks still won't be processed other than initializing a new song as needed.
This commit closes #487.