Introduce a new song group ID to track the most recent local song loaded#448
Open
KungFuFurby wants to merge 3 commits intomasterfrom
Open
Conversation
There is a situation where the level music can change during a Starman or P-Switch effect, and then the music can fail to switch over to the new local song upon the effect expiring. Since song groups are coming out in the future and this is one of the cases where it is critical that the correct song group is loaded, the variable is named to reflect its upcoming purpose. This commit closes #444.
KungFuFurby
added
the
snes-side
This user define was created in order to give AddmusicK compatibility with patches that allow P-Switch, star and directional coin timers to persist between rooms. Without this user define, the patches would be rendered incompatible, even after removing the conflicts with AddmusicK outside of AddmusicK's own code.
The regression in question is caused by the Starman/P-Switch songs retriggering on a death because of the timers being non-zero. The filter has been modified to instead remove a check for game mode $0F, which handles room transitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a situation where the level music can change during a Starman or P-Switch effect, and then the music can fail to switch over to the new local song upon the effect expiring. Since song groups are coming out in the future and this is one of the cases where it is critical that the correct song group is loaded, the variable is named to reflect its upcoming purpose.
This commit closes #444.