Open
Conversation
Four sample groups have been created, all of them prefixed with #AMMKisoPCM: They replicate the default sets used for AddmusicM. #AMMKisoPCMS00 is the default set. Note that the original SRCN IDs from Super Mario World are also implemented here: this is because of how the global instruments are handled on AddmusicK, as they are preconfigured to use the original IDs. Just make sure to keep this in mind if you even remotely try to backport these... KisoPCM refers to the original binary file that stored the samples. The core BRR filenames match AddmusicK's because they had no individual filenames, but the swappable BRR files keep their original flilenames. 06_empty.brr is omitted because it is an illegal BRR file, consisting of a single $AA byte, not counting the loop point data. All of them replace the #default and #optimized sample groups for AddmusicM songs only. This commit mentions #312. It does not close the issue due to a dependency on #31 in order to complete the sample pack restoration.
KungFuFurby
added
spc-side
I decided to keep the sXX packs separate from the main #AMMKisoPCM sample group, marking them as #AMMS01, #AMMS02 and #AMMS03 instead. #AMMS00 does not exist because it has no new samples: it only has a single empty slot, which was done because it could not be completely dummied out in the original. This commit closes #312.
KungFuFurby
added
documentation
KungFuFurby
added
the
addmusicm
3 tasks
Partially cherry picked off of commit e026687 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four sample groups have been created. They replicate the default sets used for AddmusicM. They are #AMMKisoPCM, #AMMS01, #AMMS02, and #AMMS03. #AMMKisoPCM is the default sample group, while the others are the default add-on packs. (S00 is not included because it is merely an empty slot)
Note that the original SRCN IDs from Super Mario World are also implemented here: this is because of how the global instruments are handled on AddmusicK, as they are preconfigured to use the original IDs. Just make sure to keep this in mind if you even remotely try to backport these...
KisoPCM refers to the original binary file that stored the samples. The core BRR filenames match AddmusicK's because they had no individual filenames, but the swappable BRR files keep their original flilenames.
06_empty.brr is omitted because it is an illegal BRR file, consisting of a single $AA byte, not counting the loop point data.
All of them replace the #default and #optimized sample groups for AddmusicM songs only.
This merge request mentions #312. It does not close the issue due to a dependency on #31 in order to complete the sample pack restoration.