Skip to content

Fix SinglePageWithDrawerLayout scroll #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jourdain merged 1 commit into from
Sep 10, 2025
Merged

Fix SinglePageWithDrawerLayout scroll #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
167 changes: 79 additions & 88 deletions trame_vuetify/ui/vuetify3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,79 +55,73 @@ class SinglePageLayout(VAppLayout):
.. code-block::

<v-app>
<v-layout> # layout.app_layout
<v-app-bar> # layout.toolbar
<v-app-bar-nav-icon /> # layout.icon
<v-toolbar-title> # layout.title
Trame application
</v-toolbar-title>
</v-app-bar>
<v-main /> # layout.content
<v-footer app border class="my-0 py-0"> # layout.footer
< ... />
</v-footer>
</v-layout>
<v-app-bar> # layout.toolbar
<v-app-bar-nav-icon /> # layout.icon
<v-toolbar-title> # layout.title
Trame application
</v-toolbar-title>
</v-app-bar>
<v-main /> # layout.content
<v-footer app border class="my-0 py-0"> # layout.footer
< ... />
</v-footer>
</v-app>

"""

def __init__(self, _server, template_name="main", **kwargs):
super().__init__(_server, template_name=template_name, **kwargs)
with self:
with vuetify3.VLayout() as app_layout:
self.app_layout = app_layout
with vuetify3.VAppBar() as toolbar:
self.toolbar = toolbar
self.icon = vuetify3.VAppBarNavIcon()
self.title = vuetify3.VToolbarTitle("Trame application")

self.content = vuetify3.VMain()

with vuetify3.VFooter(
app=True, classes="my-0 py-0", border=True
) as footer:
self.footer = footer
vuetify3.VProgressCircular(
indeterminate=("!!trame__busy",),
color="#04a94d",
size=16,
width=3,
classes="ml-n3 mr-1",
)
footer.add_child(
'<a href="https://kitware.github.io/trame/" '
'class="text-grey-lighten-1 text-caption text-decoration-none" '
'target="_blank">Powered by trame</a>'
)
vuetify3.VSpacer()
reload = self.server.controller.on_server_reload
if reload.exists():
with vuetify3.VBtn(
size="x-small",
density="compact",
icon=True,
# border=True,
elevation=0,
click=self.on_server_reload,
classes="mx-2",
):
vuetify3.VIcon("mdi-autorenew", size="small")

with vuetify3.VTooltip(location="top"):
with vuetify3.Template(v_slot_activator=("{ props }",)):
vuetify3.VIcon(
"mdi-help-circle",
size=14,
classes="mr-4",
v_bind=("props",),
)
html.Pre(get_trame_versions())

footer.add_child(
'<a href="https://www.kitware.com/" '
'class="text-grey-lighten-1 text-caption text-decoration-none" '
'target="_blank">© 2025 Kitware Inc.</a>'
)
with vuetify3.VAppBar() as toolbar:
self.toolbar = toolbar
self.icon = vuetify3.VAppBarNavIcon()
self.title = vuetify3.VToolbarTitle("Trame application")

self.content = vuetify3.VMain()

with vuetify3.VFooter(app=True, classes="my-0 py-0", border=True) as footer:
self.footer = footer
vuetify3.VProgressCircular(
indeterminate=("!!trame__busy",),
color="#04a94d",
size=16,
width=3,
classes="ml-n3 mr-1",
)
footer.add_child(
'<a href="https://kitware.github.io/trame/" '
'class="text-grey-lighten-1 text-caption text-decoration-none" '
'target="_blank">Powered by trame</a>'
)
vuetify3.VSpacer()
reload = self.server.controller.on_server_reload
if reload.exists():
with vuetify3.VBtn(
size="x-small",
density="compact",
icon=True,
# border=True,
elevation=0,
click=self.on_server_reload,
classes="mx-2",
):
vuetify3.VIcon("mdi-autorenew", size="small")

with vuetify3.VTooltip(location="top"):
with vuetify3.Template(v_slot_activator=("{ props }",)):
vuetify3.VIcon(
"mdi-help-circle",
size=14,
classes="mr-4",
v_bind=("props",),
)
html.Pre(get_trame_versions())

footer.add_child(
'<a href="https://www.kitware.com/" '
'class="text-grey-lighten-1 text-caption text-decoration-none" '
'target="_blank">© 2025 Kitware Inc.</a>'
)

def on_server_reload(self):
self.server.controller.on_server_reload(self.server)
Expand All @@ -147,27 +141,24 @@ class SinglePageWithDrawerLayout(SinglePageLayout):
.. code-block::

<v-app>
<v-layout> # layout.app_layout
<v-app-bar> # layout.toolbar
<v-app-bar-nav-icon /> # layout.icon
<v-toolbar-title> # layout.title
Trame application
</v-toolbar-title>
</v-app-bar>
<v-main /> # layout.content
<v-footer app border class="my-0 py-0"> # layout.footer
< ... />
</v-footer>

<v-navigation-drawer # layout.drawer
app
clipped
stateless
v-model="{template_name}_drawer"
width="width"
/>
</v-layout>

<v-app-bar> # layout.toolbar
<v-app-bar-nav-icon /> # layout.icon
<v-toolbar-title> # layout.title
Trame application
</v-toolbar-title>
</v-app-bar>
<v-main /> # layout.content
<v-footer app border class="my-0 py-0"> # layout.footer
< ... />
</v-footer>

<v-navigation-drawer # layout.drawer
app
clipped
stateless
v-model="{template_name}_drawer"
width="width"
/>
</v-app>

"""
Expand All @@ -177,7 +168,7 @@ def __init__(
):
super().__init__(_server, template_name=template_name, **kwargs)
drawer_name = f"{template_name}_drawer"
with self.app_layout:
with self:
self.drawer = vuetify3.VNavigationDrawer(
disable_resize_watcher=True,
disable_route_watcher=True,
Expand Down
Loading