Fix SinglePageWithDrawerLayout scroll #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you be more explicit why you want to remove the layout container? |
Contributor
Author
|
This fixes a bug where the drawer and the header are not sticky when scrolling the page. Here is an example of a page with a drawer, scrolled a bit, you can see that the header and the elements are not sticky as they should be: 
No scroll
Scrolled
|
Collaborator
|
I guess, now you need to fix your commit message and the formatting of the code. See https://github.com/Kitware/trame-vuetify/blob/master/CONTRIBUTING.rst and https://www.conventionalcommits.org/en/v1.0.0/ |
Remove unnecessary layout preventing Drawer from sticking to the side of the screen as intended
Jo-Byr
force-pushed
the
fix-single-page-layout-with-drawer-scroll
branch
from
e311e06 to
132b4d2
Compare
Contributor
Author
Is it better now ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary layout preventing Drawer from sticking to the side of the screen as intended