Fix invalid ktx2 files/update them for KTX v4.3.2#11
Fix invalid ktx2 files/update them for KTX v4.3.2#11JMLX42 wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
|
*looks left* I'm not sure what the source of truth is here. There is So... I created some BAT file and ran it on On this branch, there are still some errors: Not sure what to do with that, though... |
You have it right @javagl. |
That's what surprised me first: According to the description, the files in this PR have been "freshly" created, and still, many of them fail validation. But....(a bit of a rant): This repo is lacking documenation. I read the (comment-free) More importantly: The So (correct me if I'm wrong, but) I think the proper way of updating the sample environments would be:
|
|
I have some internal documentation in how to build the CLI, but IMO it does not belong to this repository.
That is surprising. IDK if the CLI is using the KTX tools from my system or builds against some vendored lib/source. I'll have a look and open an issue upstream if relevant. |
It uses a git-submodules for KTX-Software targeting the 4.0.0 tag. I'll update it to 4.3.2, rebuild, re-process the HDRs and check again. If everything checks out, I'll open a PR on glTF-IBL-Sampler. |
|
Even after updating glTF-IBL-Sampler to KTX-Software 4.3.2, some validation fails: TBF, the IMO it's a bug in how |
|
|
I ran into this issue, it took some manual breakpoint debugging inside libktx to figure out it was malformed ktx2 files. I ended up regenerating the radiance and SH radiance using cmgen from Filament to work around it. |
Hello,
I have re-generated all the
.ktx2files because they would not passktx2check.All files should not be valid according to KTX Tools v4.3.2.
I also added
prefilter.sh, which is the Bash equivalent ofprefilter.bat.Let me know if something else needs to be done for this to be merged!