Conversation
SangWJDev
reviewed
Jun 2, 2025
Collaborator
SangWJDev
left a comment
SangWJDev
left a comment
There was a problem hiding this comment.
수고하셨습니다! 확인 후 수정 부탁드릴게요
|
|
||
| @RequiredArgsConstructor | ||
| @RestController | ||
| @RequestMapping("/api/v1/review") |
Collaborator
There was a problem hiding this comment.
URI 코드컨벤션 기준으로 네이밍 부탁드립니다! 복수형 ~
heeejinin
reviewed
Jun 2, 2025
| throw new CustomException(ReviewErrorCode.UNAUTHORIZED_REVIEW_ACCESS); | ||
| } | ||
|
|
||
| reservationRepository.deleteById(reviewId); |
Collaborator
There was a problem hiding this comment.
예약 Repository에서 deleteById 메서드를 사용하고 있습니다.
리뷰 Repository로 수정이 필요해 보입니다!
|
|
||
| private Long targetId; | ||
|
|
||
| private Integer rating; |
Collaborator
There was a problem hiding this comment.
기업 답변에서 리뷰는 1~5점으로 점수를 매길 수 있다고 봤었는데 min,max 조건 있어야 할 것 같습니다. 그 외에도 코멘트는 최소 10이상 작성해야한다는 등.. valid 조건 있으면 좋을 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 목적 및 내용
✏️ 변경 사항
📸 스크린샷 (선택사항)
✅ 체크리스트
🔗 관련 이슈 (선택사항)