Merged
Conversation
soohoioa
requested review from
SangWJDev and
heeejinin
and removed request for
SangWJDev
refactor : 결제 로직 수정
…ture/39-payment-ing # Conflicts: # payment/build.gradle.kts # payment/src/main/java/com/homeaid/controller/PaymentController.java # payment/src/main/java/com/homeaid/repository/PaymentRepository.java # payment/src/main/java/com/homeaid/service/PaymentServiceImpl.java
heeejinin
reviewed
May 31, 2025
Collaborator
heeejinin
left a comment
heeejinin
left a comment
There was a problem hiding this comment.
PaymentService가 누락된 것 같습니다
실패 케이스 Swagger 문서화, 서비스 단 @transactional 추가로 데이터 일관성 보장되면 더 좋을 것 같아요
| @RequiredArgsConstructor | ||
| public class PaymentController { | ||
|
|
||
| private final PaymentService paymentService; |
Collaborator
There was a problem hiding this comment.
PaymentService 코드는 Service 패키지에 없는데 누락된 것 같습니다
| @PostMapping | ||
| @Operation(summary = "결제 성공", responses = { | ||
| @ApiResponse(responseCode = "201", description = "결제 성공", | ||
| content = @Content(schema = @Schema(implementation = PaymentResponseDto.class))), |
Collaborator
There was a problem hiding this comment.
실패 했을 경우도 있으면 좋을 것 같아요!
payment/src/main/java/com/homeaid/controller/SettlementController.java
Outdated
Show resolved
Hide resolved
| import jakarta.persistence.JoinColumn; | ||
| import jakarta.persistence.ManyToOne; | ||
| import jakarta.persistence.Table; | ||
| import java.math.BigDecimal; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 목적 및 내용
✏️ 변경 사항
📸 스크린샷 (선택사항)
✅ 체크리스트
🔗 관련 이슈 (선택사항)