Skip to content

Performance fix: get rid of GetRoom called on every redraw of shuttle #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bqr1s wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Performance fix: get rid of GetRoom called on every redraw of shuttle #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Source/1.5/Comp/CompShipBay.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ public override void PostExposeData()
public CellRect bayRect;
Matrix4x4 matrix = new Matrix4x4();
public HashSet<IntVec3> reservedArea = new HashSet<IntVec3>();
private bool? needDrawRoof = null;
HashSet<CompFueledTravel> dockedShuttles = new HashSet<CompFueledTravel>();
CompRefuelable compRefuelable;
CompPowerTrader compPowerTrader;
Expand Down Expand Up @@ -140,7 +141,12 @@ public IntVec3 CanFitShuttleSize(VehiclePawn vehicle) //we only have square shut
public override void PostDraw()
{
base.PostDraw();
if ((Find.PlaySettings.showRoofOverlay || parent.GetRoom() != null && parent.GetRoom().Cells.Any(c => c.Fogged(parent.Map))) && parent.Position.Roofed(parent.Map))
// Get room is slow if not enclosed, so update flag rarely.
if (needDrawRoof == null || Find.TickManager.TicksGame % 60 == 0)
{
needDrawRoof = parent.GetRoom() != null && parent.GetRoom().Cells.Any(c => c.Fogged(parent.Map));
}
if ((Find.PlaySettings.showRoofOverlay || (needDrawRoof ?? false)) && parent.Position.Roofed(parent.Map))
{
//roofedGraphic.Draw(new Vector3(parent.DrawPos.x, Altitudes.AltitudeFor(AltitudeLayer.MoteOverhead), parent.DrawPos.z), parent.Rotation, parent);

Expand Down