Skip to content

[Fix] [Reporting] Custom New Line [LOYAL-2704] #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marfoldi merged 2 commits into from
Oct 20, 2021
Merged

[Fix] [Reporting] Custom New Line [LOYAL-2704] #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b867136
[LOYAL-2704] Add `new_line` option to @definition
Oct 19, 2021
b3e7b25
[LOYAL-2704] Memoizing `newline`
Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions lib/slither/generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ def stream(data, io)
private

def generate_file_output
output = @builder.join("\n")
output.concat("\n") if add_trailing_newline?
output = @builder.join(newline)
output.concat(newline) if add_trailing_newline?
output
end

Expand All @@ -48,16 +48,20 @@ def add_trailing_newline?
end

def newline_needed(first_line)
first_line ? "".freeze : "\n".freeze
first_line ? "".freeze : newline
end

def format_row_for_streaming(row, section, first_line)
if add_trailing_newline?
section.format(row) + "\n".freeze
section.format(row) + newline
else
add_newline = newline_needed(first_line)
section.format(row).prepend(add_newline)
end
end

def newline
@newline ||= @definition.options[:new_line] || "\n".freeze
end
end
end