Skip to content

[Fix] [Reporting] Custom New Line [LOYAL-2704] #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marfoldi merged 2 commits into from
Oct 20, 2021
Merged

[Fix] [Reporting] Custom New Line [LOYAL-2704] #6

marfoldi merged 2 commits into from
Oct 20, 2021

Conversation

@marfoldi
Copy link

@marfoldi marfoldi commented Oct 19, 2021 •
edited
Loading

Background

Support CRLF endings.

Approach

Copy ryanwood#12.

imrefoldeskaligo
imrefoldeskaligo approved these changes Oct 20, 2021
View reviewed changes
Copy link

@imrefoldeskaligo imrefoldeskaligo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marfoldi marfoldi merged commit 899594f into master Oct 20, 2021
@marfoldi marfoldi deleted the fix/custom_new_line branch October 20, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrebalazs55 andrebalazs55 Awaiting requested review from andrebalazs55

1 more reviewer

@imrefoldeskaligo imrefoldeskaligo imrefoldeskaligo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marfoldi @imrefoldeskaligo