Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def __post_init__(self): | ||
| if self.query_whitelist is None: | ||
| self.query_whitelist = set() | ||
| if self.tag is None: | ||
| self.tag = set() |
There was a problem hiding this comment.
Avoid writing empty tag sets to DynamoDB
When the request omits tags (the usual case for new links), _parse_request_data leaves tag as None, but DelibirdLink.__post_init__ turns that into an empty set and PortalLinkCreate/Update always write that value to DelibirdLinkTableModel.tag. DynamoDB/PynamoDB reject empty sets (UnicodeSetAttribute serialization raises a validation error), so creating or updating a link without tags will now fail. Preserve None or skip persisting when the tag list is empty so blank-tag submissions continue to succeed.
Useful? React with 👍 / 👎.
No description provided.