Skip to content

update: リンクにメモとタグ情報を付与できるように#26

Merged
KO1231 merged 4 commits intodevelopfrom
feature/add-memo-tag
Dec 8, 2025
Merged

update: リンクにメモとタグ情報を付与できるように#26
KO1231 merged 4 commits intodevelopfrom
feature/add-memo-tag

Conversation

@KO1231
Copy link
Owner

@KO1231 KO1231 commented Dec 8, 2025

No description provided.

@KO1231 KO1231 merged commit e3ed730 into develop Dec 8, 2025
1 check passed
@KO1231 KO1231 deleted the feature/add-memo-tag branch December 8, 2025 06:18
@KO1231 KO1231 mentioned this pull request Dec 8, 2025
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 58 to +62
def __post_init__(self):
if self.query_whitelist is None:
self.query_whitelist = set()
if self.tag is None:
self.tag = set()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid writing empty tag sets to DynamoDB

When the request omits tags (the usual case for new links), _parse_request_data leaves tag as None, but DelibirdLink.__post_init__ turns that into an empty set and PortalLinkCreate/Update always write that value to DelibirdLinkTableModel.tag. DynamoDB/PynamoDB reject empty sets (UnicodeSetAttribute serialization raises a validation error), so creating or updating a link without tags will now fail. Preserve None or skip persisting when the tag list is empty so blank-tag submissions continue to succeed.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant