Skip to content

v1.4.0#27

Merged
KO1231 merged 1 commit intomainfrom
develop
Dec 8, 2025
Merged

v1.4.0#27
KO1231 merged 1 commit intomainfrom
develop

Conversation

@KO1231
Copy link
Owner

@KO1231 KO1231 commented Dec 8, 2025

@KO1231 KO1231 merged commit 5256ace into main Dec 8, 2025
2 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 58 to +62
def __post_init__(self):
if self.query_whitelist is None:
self.query_whitelist = set()
if self.tag is None:
self.tag = set()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid saving empty tag set to Dynamo

Because DelibirdLink.__post_init__ forces tag to an empty set even when the request omits tags, and both create/update always persist tag into UnicodeSetAttribute (DelibirdLinkTableModel.tag), any create or edit request without tags will attempt to write an empty set. DynamoDB rejects empty string sets, so untagged link creation/update will fail with a ValidationException instead of succeeding.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant