Conversation
KO1231
commented
Dec 8, 2025
- update: リンクにメモとタグ情報を付与できるように #26
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def __post_init__(self): | ||
| if self.query_whitelist is None: | ||
| self.query_whitelist = set() | ||
| if self.tag is None: | ||
| self.tag = set() |
There was a problem hiding this comment.
Avoid saving empty tag set to Dynamo
Because DelibirdLink.__post_init__ forces tag to an empty set even when the request omits tags, and both create/update always persist tag into UnicodeSetAttribute (DelibirdLinkTableModel.tag), any create or edit request without tags will attempt to write an empty set. DynamoDB rejects empty string sets, so untagged link creation/update will fail with a ValidationException instead of succeeding.
Useful? React with 👍 / 👎.